fix(roles): Minor fix in set_permissions

This commit is contained in:
Ferdinand Thiessen 2021-12-18 04:19:07 +01:00
parent 1db3391826
commit 691345cf40
1 changed files with 5 additions and 6 deletions

View File

@ -12,7 +12,7 @@ def get_all():
return Role.query.all() return Role.query.all()
def get(role_name: Union[int,str]) -> Role: def get(role_name: Union[int, str]) -> Role:
"""Get role by ID or name """Get role by ID or name
Args: Args:
role_name: Name or ID of the role role_name: Name or ID of the role
@ -46,11 +46,10 @@ def update_role(role, new_name):
def set_permissions(role, permissions): def set_permissions(role, permissions):
for name in permissions: perms = Permission.query.filter(Permission.name.in_(permissions)).all()
p = Permission.query.filter(Permission.name.in_(permissions)).all() if len(perms) < len(permissions):
if not p or len(p) < len(permissions): raise BadRequest("Invalid permission name")
raise BadRequest("Invalid permission name >{}<".format(name)) role.permissions = list(perms)
role.permissions = list(p)
db.session.commit() db.session.commit()