Flaschengeist/flaschengeist
Flaschengeist
/
flaschengeist
7
0
Fork 0
Code Issues 20 Pull Requests Packages Projects Releases 2 Wiki Activity

feat(plugins): Load metadata from entry points / distribution #24

Merged
crimsen merged 2 commits from proposal/metadata2 into develop 2022-03-08 08:13:52 +00:00
Conversation 1 Commits 2 Files Changed 11 +104 -98
ferfissimo commented 2022-02-21 21:38:56 +00:00
Owner
Copy Link

This is a more light weight approach to fix #23.

Instead of an extra class and more overhead inside the plugin definition we simply use the distributions metadata (e.g. from setup.cfg).
No need for extra name or ID as the entry point already has a name which must be unique.

Instead of pkg_resources importlib_metadata is used, and can be replaced with the standard library importlib.metadata when we require python 3.10 (version with 3.9 does not provide the Distribution with the entry points).

This is a more light weight approach to fix #23. Instead of an extra class and more overhead inside the plugin definition we simply use the distributions metadata (e.g. from `setup.cfg`). No need for extra name or ID as the entry point already has a name which must be unique. Instead of `pkg_resources` `importlib_metadata` is used, and can be replaced with the standard library `importlib.metadata` when we require python 3.10 (version with 3.9 does not provide the Distribution with the entry points).
ferfissimo added the
💡 enhancement
🎒 backend
 labels 2022-02-21 21:38:56 +00:00
ferfissimo added 1 commit 2022-02-21 21:38:57 +00:00
ferfissimo force-pushed proposal/metadata2 from d580227f78 to 27a086a5c0 2022-02-22 10:07:49 +00:00 Compare
ferfissimo force-pushed proposal/metadata2 from 27a086a5c0 to 3589564b7f 2022-02-22 10:12:46 +00:00 Compare
ferfissimo added a new dependency 2022-02-22 23:07:50 +00:00
#20 feature/migrations, closes #19
ferfissimo added 1 commit 2022-02-23 14:20:39 +00:00
ci/woodpecker/push/lint Pipeline was successful Details
ci/woodpecker/push/test Pipeline was successful Details
ci/woodpecker/pr/lint Pipeline was successful Details
ci/woodpecker/pr/test Pipeline was successful Details
6f35e17fba feat(plugins): Load metadata from entry points / distribution
ferfissimo added 1 commit 2022-03-07 13:36:35 +00:00
ci/woodpecker/push/lint Pipeline was successful Details
ci/woodpecker/push/test Pipeline was successful Details
ci/woodpecker/pr/lint Pipeline was successful Details
ci/woodpecker/pr/test Pipeline was successful Details
2d4c8ebfd9 fix(plugins): Fix functions using id instead of name property
crimsen commented 2022-03-08 08:13:34 +00:00
Owner
Copy Link

Sieht gut aus und funktioniert. flaschengeist-events muss jedoch noch das Plugin angepasst werden. Aber das kann ja extra gemacht werden.

Sieht gut aus und funktioniert. flaschengeist-events muss jedoch noch das Plugin angepasst werden. Aber das kann ja extra gemacht werden.
crimsen merged commit e09d563e93 into develop 2022-03-08 08:13:52 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
🛃 types

Issue with @flaschengeist/types

  
👪 users

Issue with @flaschengeist/users

  
invalid

Something is wrong

  
wontfix

This won't be fixed

  
🚀 announcement

news from the project

  
🎒 backend

issue related to backend

  
🐞 bug

Something is not working

  
🐋 docker

issue with the docker files

  
💡 enhancement

New feature

  
📺 frontend

issue related to frontend

  
🤔 question

More information is needed

  
🔗duplicate

This issue or pull request already exists

No Label
🛃 types
👪 users
invalid
wontfix
🚀 announcement
🎒 backend
🐞 bug
🐋 docker
💡 enhancement
📺 frontend
🤔 question
🔗duplicate
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Blocks
#20 feature/migrations, closes #19
Flaschengeist/flaschengeist
Reference: Flaschengeist/flaschengeist#24
No description provided.
Delete Branch "proposal/metadata2"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?